confirm collection delete success #1428
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaiahWren
requested review from
MilanPospisil,
himdel,
nixocio and
skochay330
vishsanghishetty
approved these changes
Jan 9, 2024
Contributor
|
@ShaiahWren looks like this will need a rebase? :) And, LGTM too, although
this will work both when the collection doesn't exist because it was removed, or when the table is reloading/rendering and not displaying the collection at the moment better to search for the collection and check the not found screen exists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pr adds a simple line confirming the success of collection deletion. Let me know if/how this test could be even more robust. Thank you!